Skip to content

Commit

Permalink
Pass full path to pydocstyle (#3995)
Browse files Browse the repository at this point in the history
* Pass full path to pydocstyle

* Update pydocstyle tests
  • Loading branch information
brendanator committed Dec 9, 2021
1 parent 9a01836 commit b974407
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion ale_linters/python/pydocstyle.vim
Expand Up @@ -29,7 +29,7 @@ function! ale_linters#python#pydocstyle#GetCommand(buffer) abort

return ale#Escape(l:executable) . l:exec_args
\ . ale#Pad(ale#Var(a:buffer, 'python_pydocstyle_options'))
\ . ' %s:t'
\ . ' %s'
endfunction

function! ale_linters#python#pydocstyle#Handle(buffer, lines) abort
Expand Down
16 changes: 8 additions & 8 deletions test/linter/test_pydocstyle.vader
@@ -1,45 +1,45 @@
Before:
call ale#assert#SetUpLinterTest('python', 'pydocstyle')
call ale#test#SetFilename('test.py')
call ale#test#SetFilename('example/test.py')

After:
call ale#assert#TearDownLinterTest()

Execute(The pydocstyle command callback should return default string):
AssertLinterCwd '%s:h'
AssertLinter 'pydocstyle', ale#Escape('pydocstyle') . ' %s:t'
AssertLinter 'pydocstyle', ale#Escape('pydocstyle') . ' %s'

Execute(The pydocstyle command callback should allow options):
let g:ale_python_pydocstyle_options = '--verbose'

AssertLinter 'pydocstyle', ale#Escape('pydocstyle') . ' --verbose %s:t'
AssertLinter 'pydocstyle', ale#Escape('pydocstyle') . ' --verbose %s'

Execute(The pydocstyle executable should be configurable):
let g:ale_python_pydocstyle_executable = '~/.local/bin/pydocstyle'

AssertLinter '~/.local/bin/pydocstyle',
\ ale#Escape('~/.local/bin/pydocstyle') . ' %s:t'
\ ale#Escape('~/.local/bin/pydocstyle') . ' %s'

Execute(Setting executable to 'pipenv' appends 'run pydocstyle'):
let g:ale_python_pydocstyle_executable = 'path/to/pipenv'

AssertLinter 'path/to/pipenv',
\ ale#Escape('path/to/pipenv') . ' run pydocstyle %s:t'
\ ale#Escape('path/to/pipenv') . ' run pydocstyle %s'

Execute(Pipenv is detected when python_pydocstyle_auto_pipenv is set):
let g:ale_python_pydocstyle_auto_pipenv = 1
call ale#test#SetFilename('../test-files/python/pipenv/whatever.py')

AssertLinter 'pipenv', ale#Escape('pipenv') . ' run pydocstyle %s:t'
AssertLinter 'pipenv', ale#Escape('pipenv') . ' run pydocstyle %s'

Execute(Setting executable to 'poetry' appends 'run pydocstyle'):
let g:ale_python_pydocstyle_executable = 'path/to/poetry'

AssertLinter 'path/to/poetry',
\ ale#Escape('path/to/poetry') . ' run pydocstyle %s:t'
\ ale#Escape('path/to/poetry') . ' run pydocstyle %s'

Execute(Poetry is detected when python_pydocstyle_auto_poetry is set):
let g:ale_python_pydocstyle_auto_poetry = 1
call ale#test#SetFilename('../test-files/python/poetry/whatever.py')

AssertLinter 'poetry', ale#Escape('poetry') . ' run pydocstyle %s:t'
AssertLinter 'poetry', ale#Escape('poetry') . ' run pydocstyle %s'

0 comments on commit b974407

Please sign in to comment.