Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlight linenr without enabling signs? #2752

Open
JeanMertz opened this issue Sep 4, 2019 · 4 comments
Open

highlight linenr without enabling signs? #2752

JeanMertz opened this issue Sep 4, 2019 · 4 comments

Comments

@JeanMertz
Copy link
Contributor

This request is similar to #741, except that I'd like to use line number highlighting (g:ale_sign_highlight_linenrs), but not have Ale touch the signcolumn(s).

The reason being:

  1. highlighting an entire line is too obtrusive
  2. I'd like to keep the sign columns reserved for other plugins, and use line number coloring for Ale specifically.

I can create a PR when I find some time, but wanted to make sure this is something you're willing to entertain.

@JeanMertz
Copy link
Contributor Author

I should clarify: I can set g:ale_sign_error etc to '' and remove any highlighting, but I suspect that would still make ALE potentially override other signs being shown at that line.

However, thinking some more about this, I guess that plus setting g:ale_sign_offset to 0 might actually be enough to make this work?

I'll leave this open in case that's not true, or you'd like to make this a bit easier to use, but feel free to close this if what I propose is what you think is the best approach without changing Ale.

@JeanMertz
Copy link
Contributor Author

Ah never mind, it's priority that I'd need to change, not offset (which is just an ID that has to be unique). So this would still require changes to Ale as far as I know, either allowing changing the priority of the signs, or supporting the original request.

@w0rp
Copy link
Member

w0rp commented Sep 11, 2019

You might be able to implement this by only setting text= if the sign text is !empty.

@w0rp w0rp added this to To Do in On the Radar via automation Sep 11, 2019
@hsanson
Copy link
Contributor

hsanson commented Sep 27, 2019

@JeanMertz support for sign-priority was added recently to ALE (see #2786 ). By setting g:ale_sign_priority to a low value (< 10) you can ensure ALE signs will be hid by other plugin signs.

Would be great if you can test this and close this issue.

@w0rp w0rp removed this from To Do in On the Radar Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants