569 support vim sign group and priority #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 23, 2019 10:42
The sign-group feature is only available for nvim 0.4.0 and vim 8.1 upwards.
This allows users to set a priority to ALE signs to take precedence over other plugin signs. Only works with nvim 0.4.0 and vim 8.1 upwards.
|
@w0rp this pull request seems to break the tests somehow and my understanding on how these run is not enough to find the issue. If I run the tests (e.g. ./run-tests) with the master branch all works ok but when running the tests with the changes of this PR, the tests hang forever after completing the vader tests: |
w0rp
requested changes
Sep 23, 2019
1. The sign-group and sign-priority features are available only after vim patch 614. 2. Update all sign tests to use group for supported nvim/vim versions. 3. Use same ale#sign#ParsePattern() on tests. 4. New ale#sign#Clear() method for use within tests.
w0rp
approved these changes
Sep 25, 2019
|
Cheers! 🍻 |
This was referenced Sep 25, 2019
timlag1305
pushed a commit
to timlag1305/ale
that referenced
this pull request
Nov 5, 2019
* Use sign-group only on supported vim versions. The sign-group feature is only available in nvim 0.4.0 and vim 8.1.614. * Add priority to ALE signs. This allows users to set a priority to ALE signs to take precedence over other plugin signs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sign-group and sign-priority support to ALE. With sign-group ALE can manipulate the signs without risk of conflicts with other plugins that also set signs and with priority users are able to adjust ALE signs priority to override or be overridden by other plugins signs.