Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default navigation configuration (plus command cleanup) #3019

Closed
w0rp opened this issue Feb 24, 2020 · 1 comment
Closed

Default navigation configuration (plus command cleanup) #3019

w0rp opened this issue Feb 24, 2020 · 1 comment
Assignees
@w0rp
Labels
enhancement LSP Any issue relating to LSP or tsserver
Projects
On the Radar

Comments

@w0rp
Copy link
Member

w0rp commented Feb 24, 2020

Commands in ALE should be slowly cleaned up so instead of having multiple commands, there's a single command with options, like :ALECommand -some-option. ALEGoToDefinition should be changed so it uses options like these, and the other commands like :ALEGoToDefinitionInTab should be deprecated, so they can be removed far into the future, and so forth.

:ALEGoToTypeDefinition should be modified similarly.

In addition to providing options for the two, I would like to an an option, possibly named ale_default_navigation for deciding how ALE should navigate to buffers via "go to definition," "go to type definition," finding references, and so on by default. The current default will remain the same, but the option will be configurable such that you can jump to a file location in a new tab by default, etc., with the explicit options always overriding the default.
@w0rp w0rp added enhancement LSP Any issue relating to LSP or tsserver labels Feb 24, 2020
@w0rp w0rp self-assigned this Feb 24, 2020
@w0rp w0rp added this to To Do in On the Radar Feb 24, 2020
@w0rp w0rp moved this from To Do to In Progress in On the Radar Mar 11, 2020
@w0rp w0rp closed this as completed in 82f734a Apr 15, 2020
On the Radar automation moved this from In Progress to Done Apr 15, 2020
@w0rp
Copy link
Member Author

w0rp commented Apr 15, 2020

In addition to the above, previous selections can now also be repeated with the :ALERepeatSelection command, such as the selection shown for :ALEFindReferences.

cyyever pushed a commit to cyyever/ale that referenced this issue Apr 17, 2020
@w0rp @cyyever
Closes dense-analysis#3019 - Implement default navigation
08fac99 
Default navigation for commands that jump to new locations has been
implemented with the `ale_default_navigation` variable, and all commands
that jump to locations now support `-tab`, `-split`, or `-vsplit`
arguments for overriding the default navigation behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@w0rp w0rp

Labels
enhancement LSP Any issue relating to LSP or tsserver
Projects
On the Radar
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@w0rp