Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable LanguageTool for Markdown #3379

Open
oblitum opened this issue Oct 3, 2020 · 7 comments
Open

Disable LanguageTool for Markdown #3379

oblitum opened this issue Oct 3, 2020 · 7 comments

Comments

@oblitum
Copy link
Contributor

oblitum commented Oct 3, 2020

LanguageTool is not proper for handling Markdown content. The presence of the tool in the command line will cause ALE by default to render Markdown files full of irrelevant warnings, simply because LanguageTool doesn't understand the syntax, it can only proofread plain text.

I don't use AsciiDoc, but it may be in the same boat, or worse.

I recommend that ALE changes this and leave LanguageTool for plain text files only.

To use LanguageTool for Markdown, it's best to employ a wrapper, as attempted at #3376 with TeXtidote.

@oblitum oblitum changed the title Disable LanguageTool for Markdown Remove LanguageTool for Markdown Oct 3, 2020
@hsanson
Copy link
Contributor

hsanson commented Oct 4, 2020

There is people that do use languagetool for Markdown and Asciidoc:

Rather that remove support for LanguateTool for asciidoc and markdown that seems to be useful for some I would recommend to g:ale_linters variable to disable it for these file types.

@oblitum oblitum changed the title Remove LanguageTool for Markdown Disable LanguageTool for Markdown Oct 4, 2020
@oblitum
Copy link
Contributor Author

oblitum commented Oct 4, 2020

Changed back title to disable. FWIW I think most of those user would be much more happy by using a proper wrapper instead, the LanguageTool experience on Markdown is simply bad.

@hsanson
Copy link
Contributor

hsanson commented Oct 5, 2020

Add this to your configuration for the desired result:

let g:ale_linters_ignore = {
  \   'markdown': ['languagetool'],
  \   'asciidoc': ['languagetool']
  \}

@oblitum
Copy link
Contributor Author

oblitum commented Oct 5, 2020

@hsanson it's not personal issue, I know that conf in particular already. The issue is about disabling it by default. As stated already, languagetool is not a tool for parsing Markdown, according to the authors themselves.

@JensHeinrich
Copy link

Yes, it is not but this could be considered a breaking change I think.
My suggestion would be to disable languagetool as a direct linter, if the textidote wrapper is available to get the best of both worlds.

@oblitum
Copy link
Contributor Author

oblitum commented Oct 9, 2020

@JensHeinrich could be a breaking change for those that consider it more useful than problematic, but also could be a relief for those that consider their markdown is being gratuitously filled with false positives. This was overlooked when added, it was a mistake (I was at the issue thread that added languagetool, and thought it was great).

@karlb
Copy link
Contributor

karlb commented Apr 23, 2024

So far I only got the "Possible typo: you repeated a whitespace" warning and am quite happy with the languagetool integration otherwise. Maybe we can ignore that rule for markdown by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants