Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textidote #3376

Closed
wants to merge 8 commits into from
Closed

Textidote #3376

wants to merge 8 commits into from

Conversation

bratekarate
Copy link
Contributor

@bratekarate bratekarate commented Oct 1, 2020

TODO

  • Implement Textidote support for Latex
  • Implement Textidote support for Markdown
  • Use spelllang by default
  • Add more configuration options
  • Add documentation
  • Remove languagetool as available linter for markdown (also in documentation)
  • Linting
  • Add test

Edit: Need help with the linter with regards to the doc files. I don't really understand what needs to be changed.
Nvm, fixed it. Does anyone know why the linter always fails locally for me with the following doc diff:

--- /tmp/doc-sorted.zAtYgVne	2020-10-01 15:53:52.700995107 +0200
+++ /tmp/doc.c1SKOjdu	2020-10-01 15:53:52.690995150 +0200
@@ -340 +339,0 @@
-Swift - swift-format
@@ -341,0 +341 @@
+Swift - swift-format

Only an issue locally, not a problem but a little annoying to always have a false negative.

@oblitum
Copy link
Contributor

oblitum commented Oct 1, 2020

Maybe add to TODO list to make the pull work with markdown as well? That's the reason I suggested to remove standalone languagetool from markdown files, to pick textidote instead.

@bratekarate
Copy link
Contributor Author

bratekarate commented Oct 1, 2020

@oblitum Oh 🤦 of course. I honestly didn't even know it's possible. I have committed once or twice to the project, but I am just using it with latex so far. This will be great for my markdown notes :).

I will add it to the TODO list and see if I find time. I'm very busy the next weeks, so I can't make any promises about the tests and the markdown feature. So PRs to my textidote branch are definitely welcome!

Edit: Feel also free to submit a PR (or commit directly, if you have access rights, I'm not sure) if you want to remove the &spelllang default. Works for me too.

@oblitum
Copy link
Contributor

oblitum commented Oct 1, 2020

@bratekarate I have no commit access, and not much time either :/

@stale
Copy link

stale bot commented Oct 29, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Oct 29, 2020
@stale stale bot closed this Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PRs a bot will close automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants