Attempting to add support for PHP

[scwood]

Hello, I am trying to add support for php with php -l. I've added a directory called php to ale_linters and added a file called php.vim.

Here's my code so far:

if exists('g:loaded_ale_linters_php_php')
    finish
endif

let g:loaded_ale_linters_php_php = 1

function! ale_linters#php#php#Handle(buffer, lines)
    " Matches patterns like the following:
    "
    " Parse error: parse error in - on line 7
    let pattern = 'Parse error: \(.\+\) on line \(\d\+\)'
    let output = []

    for line in a:lines
        let l:match = matchlist(line, pattern)

        if len(l:match) == 0
            continue
        endif

        " vcol is Needed to indicate that the column is a character.
        call add(output, {
        \   'bufnr': a:buffer,
        \   'lnum': l:match[1] + 0,
        \   'vcol': 0,
        \   'col': 0,
        \   'text': l:match[0],
        \   'type': 'E',
        \   'nr': -1,
        \})
    endfor

    return output
endfunction

call ALEAddLinter('php', {
\   'name': 'php',
\   'executable': 'php',
\   'output_stream': 'stderr',
\   'command': 'php -l -',
\   'callback': 'ale_linters#php#php#Handle',
\})

When I run cat myfile.php | php -l I get sytnax errors. But in the buffer nothing shows up.

[w0rp]

Hmm, the problem here isn't obvious to me yet. I might have a go at adding this to the repo myself and credit you as the author. It looks okay, so it's probably some minor bug.

[scwood]

Okay, let me know if there's something that needs to be changed. I would like to keep contributing. Great plugin.

[w0rp]

I have pushed your code now with some minor changes. php needed -- instead of - to read from stdin, which is a bit odd, but it works. The second error was that the regex matches start at index 1, and not 0. That's a common mistake, which I didn't notice until I started playing around with it.

[scwood]

Thanks for explaining those changes. I have the latest code, but I'm still
not seeing any linting feedback in my buffer.

Here's the code I'm using:

<?php
echo "Hello!" // this needs a semi-colon

I have pushed your code now with some minor changes. php needed --
instead of - to read from stdin, which is a bit odd, but it works. The
second error was that the regex matches start at index 1, and not 0.
That's a common mistake, which I didn't notice until I started playing
around with it.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#37 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AItA-uQz2tUR1g2lsaqevcls4XOqXFraks5qwY10gaJpZM4KNHXm
.

[w0rp]

Ah, there is one bug left to be fixed which I can fix tomorrow. Some errors go one line beyond the last line in the file, so they don't appear at all. This is such an error. I'm thinking I might make that automatic for any linter which is added.

[w0rp]

@scwood If you pull again, you should see a warning for the missing semicolon now. I fixed errors which have line numbers beyond the end of the file for any linter now.

[scwood]

I'm not sure what I'm doing wrong. I'm updated to the latest code. On the left with the C file Ale is working great, but on the php file nothing happens:

[w0rp]

Hmm, could you paste the output of :!php -l -- < test.php and your php version? Maybe there is something wrong there.

I'll reopen the issue while you're having issues.

[scwood]

Sure, here's the ouput of :!php -l -- < test.php:

Parse error: parse error, expecting `','' or `';'' in - on line 4
Errors parsing -

shell returned 255

Press ENTER or type command to continue

And php:

$ php --version
PHP 5.5.36 (cli) (built: May 29 2016 01:07:06)
Copyright (c) 1997-2015 The PHP Group
Zend Engine v2.5.0, Copyright (c) 1998-2015 Zend Technologies

[deathmaz]

Hi, for me Ale works fine with php files:
https://asciinema.org/a/2h6zlyi99ialjdeia9gmiwteo

php -v

PHP 7.0.11 (cli) (built: Sep 16 2016 18:52:44) ( NTS )
Copyright (c) 1997-2016 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2016 Zend Technologies

[scwood]

Hmmm, I tried with Vim and NVim, no dice. Also tried with a minimal vimrc.

[w0rp]

I'm not quite certain where the problem lies at the moment. I might try installing that version of PHP tomorrow and see if there are any problems there. The PHP linting works for me at the moment. Have you checked the linters for other languages? I wonder if the problem is specific to the PHP linter.

[scwood]

Yeah no issues using the other linters... I updated my plugin this morning. Still digging

[scwood]

I have no idea what's going on with this. I've installed ale on my work computer and php works without any issues, I don't know why it's broken on my laptop. I've reinstalled vim, made sure I'm not running my forked version, etc. etc. I'm just going to close for now.

[w0rp]

@scwood I think I finally figured out what was going on. I tried the PHP linter on a friend's machine, and it was outputting the errors to stdout, whereas my machine outputs them to stderr. I added support to the plugin for reading from both streams, so it will just pick up all lines of output and parse them. This might be one of those things you can change in php.ini. Let me know if it works for you now.

[scwood]

That did it, thanks so much.

[w0rp]

Nice! You're welcome.