Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for erb-lint #3911

Closed
evenreven opened this issue Sep 18, 2021 · 2 comments
Closed

Add support for erb-lint #3911

evenreven opened this issue Sep 18, 2021 · 2 comments
Labels
new tool Support for new linters, fixers, etc.

Comments

@evenreven
Copy link

Name: erb-lint
URL: https://github.com/Shopify/erb-lint

erb-lint is a Rubocop-based linter and fixer developed at Shopify for embedded ruby (.html.erb files). It used to be hard to integrate with editors, but this recently changed, and there is now a VS Code integration that works quite well (both as linter and autofixer). I've only used Ruumba (the other Rubocop-based erb linter) for a little while, but from what I can tell the main advantage of erb-lint is that it comes with real HTML parsing and linting as well, i.e. it doesn't just lint the Ruby snippets. (Technically this is done by a different gem called better-html, but it's bundled with erb-lint and you don't have to run it separately.)

I think erb-lint is currently the best linter for this format, and since I use (neo)vim and not VS Code, I'd love to see it supported by ALE! (Sadly I don't know enough to help with a PR.)

@evenreven evenreven added the new tool Support for new linters, fixers, etc. label Sep 18, 2021
@roelandmoors
Copy link
Contributor

I think it is similar to the Ruumba linter. I'll give it a try.

This was referenced Oct 7, 2021
@evenreven
Copy link
Author

Since this is implemented and merged now, I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new tool Support for new linters, fixers, etc.
Projects
None yet
Development

No branches or pull requests

2 participants