-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for erblint #3931
Add support for erblint #3931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test for the handler method. See examples inside the test/handler folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good.
(Dumb) question: I tried it now and it works well (thank you both!), but is it meant to autofix as well the way the Rubocop linter/fixer does? Autofixing is supported by erblint, and the VS Code extension does it as well, but I get the let g:ale_fixers = {
\ '*': ['remove_trailing_lines', 'trim_whitespace'],
\'scss': ['stylelint'],
\'css': ['stylelint'],
\'ruby': ['rubocop'],
\'eruby': ['erblint'],
\'javascript': ['prettier', 'eslint'],
\'json': ['prettier'],
\'slim': ['slim-lint'],
\'yaml': ['prettier'],
\'html': ['prettier'],
\} If it's out of scope for this PR, that's perfectly understandable. |
@evenreven unfortunatelly this PR only adds erblint as a linter. Supporting it as fixer should not be difficult. Check the ale/autoload/ale/fixers/rubocop.vim file for a simple example. |
yes, I only created the linter. Realized too late it could be used as fixer. Maybe I'll still add this if I find some time. |
Add support for erblint as asked in issue #3911