Incomplete textDocument/didSave implementation

[Rubonnek]

Information

VIM version
NVIM v0.6.0-dev+141-gaa07d06bf
Build type: RelWithDebInfo

Operating System: Arch Linux

What went wrong

Connecting ALE as an LSP client to Godot Game Engine would occasionally crash the engine. After the bug was fixed on the engine, it was discovered that the textDocument/didSave implementation within ALE is missing several fields in the message.

Reproducing the bug

ALE has an incomplete LSP implementation of textDocument/didSave.

See:

ale/autoload/ale/lsp/message.vim

Lines 80 to 86 in c9c89a1

	function! ale#lsp#message#DidSave(buffer) abort
	return [1, 'textDocument/didSave', {
	\ 'textDocument': {
	\ 'uri': ale#path#ToURI(expand('#' . a:buffer . ':p')),
	\ },
	\}]
	endfunction

Which is missing the file contents, and possibly other fields according to the official LSP specification.

See godotengine/godot#53261 (comment) for more information.

:ALEInfo

N/A