Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:ALERename does not pick up ruby methods with a trailing question mark #4285

Open
erikw opened this issue Aug 17, 2022 · 0 comments
Open

:ALERename does not pick up ruby methods with a trailing question mark #4285

erikw opened this issue Aug 17, 2022 · 0 comments
Labels

Comments

@erikw
Copy link
Contributor

erikw commented Aug 17, 2022

Information

VIM version

NVIM v0.7.2
Build type: Release

Operating System: macOS 12.5

What went wrong

I have a ruby method like this

def whatever?
   # return false or true
end
  • I put the text cursor inside whatever?, say on the h
  • I type :ALERename<CR>
  • I'm prompted with New name: whatever

Here we see already that the rename command did not pick up the trailing question mark. If I go on to rename this what will happen is that references are renamed, but not the actual method definition (the current line).

From how it looks to me, the rename command is not aligned with what are valid method names in Ruby. The issue could of course be with one of the tools configured for ruby here with Ale: solargraph & rubocop.

:ALEInfo

Expand
 Current Filetype: ruby
Available Linters: ['brakeman', 'cspell', 'debride', 'rails_best_practices', 'reek', 'rubocop', 'ruby', 'solargraph', 'sorbet', 'standardrb']
   Linter Aliases:
'sorbet' -> ['srb']
  Enabled Linters: ['ruby', 'solargraph']
  Ignored Linters: []
 Suggested Fixers: 
  'prettier' - Apply prettier to a file.
  'remove_trailing_lines' - Remove all blank lines at the end of a file.
  'rubocop' - Fix ruby files with rubocop --auto-correct.
  'rufo' - Fix ruby files with rufo
  'sorbet' - Fix ruby files with srb tc --autocorrect.
  'standardrb' - Fix ruby files with standardrb --fix
  'trim_whitespace' - Remove all trailing whitespace characters at the end of every line.
 Linter Variables:

let g:ale_ruby_rails_best_practices_executable = 'rails_best_practices'
let g:ale_ruby_rails_best_practices_options = ''
let g:ale_ruby_ruby_executable = 'ruby'
let g:ale_ruby_solargraph_executable = 'solargraph'
let g:ale_ruby_solargraph_options = {}
 Global Variables:

let g:ale_cache_executable_check_failures = v:null
let g:ale_change_sign_column_color = 0
let g:ale_command_wrapper = ''
let g:ale_completion_delay = 100
let g:ale_completion_enabled = 1
let g:ale_completion_max_suggestions = 50
let g:ale_disable_lsp = 0
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '%code: %%s'
let g:ale_echo_msg_info_str = 'Info'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_fix_on_save = 1
let g:ale_fixers = {'*': ['prettier'], 'ruby': ['rubocop'], 'python': ['autoflake', 'black', 'isort']}
let g:ale_history_enabled = 1
let g:ale_history_log_output = 1
let g:ale_keep_list_window_open = 0
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_filetype_changed = 1
let g:ale_lint_on_insert_leave = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'normal'
let g:ale_linter_aliases = {}
let g:ale_linters = {'vim': ['vimls'], 'go': ['gopls'], 'json': ['jsonls'], 'sh': ['language_server'], 'ruby': ['solargraph', 'ruby'], 'python': ['pyright', 'flake8']}
let g:ale_linters_explicit = 0
let g:ale_linters_ignore = {}
let g:ale_list_vertical = 0
let g:ale_list_window_size = 10
let g:ale_loclist_msg_format = '%code: %%s'
let g:ale_max_buffer_history_size = 20
let g:ale_max_signs = -1
let g:ale_maximum_file_size = v:null
let g:ale_open_list = 0
let g:ale_pattern_options = v:null
let g:ale_pattern_options_enabled = v:null
let g:ale_root = {}
let g:ale_set_balloons = 0
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = 0
let g:ale_sign_error = '>>'
let g:ale_sign_info = '--'
let g:ale_sign_offset = 1000000
let g:ale_sign_style_error = '>>'
let g:ale_sign_style_warning = '--'
let g:ale_sign_warning = '--'
let g:ale_sign_highlight_linenrs = 0
let g:ale_statusline_format = v:null
let g:ale_type_map = {}
let g:ale_use_global_executables = v:null
let g:ale_virtualtext_cursor = 0
let g:ale_warn_about_trailing_blank_lines = 1
let g:ale_warn_about_trailing_whitespace = 1
@erikw erikw added the bug label Aug 17, 2022
erikw added a commit to erikw/ale that referenced this issue Aug 17, 2022
To make the bug reports a bit more readable. See an example of usage
here: dense-analysis#4285
hsanson pushed a commit that referenced this issue Aug 17, 2022
To make the bug reports a bit more readable. See an example of usage
here: #4285
mnikulin pushed a commit to mnikulin/ale that referenced this issue Nov 12, 2023
To make the bug reports a bit more readable. See an example of usage
here: dense-analysis#4285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant