Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for remark-lint #1010

Merged
merged 1 commit into from Oct 19, 2017
Merged

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Oct 19, 2017

I added support for remark-lint to ale. It is a linter for markdown. I marked this linter as existing file only because stdin or temporary file is not available. remark-lint assumes .remarkrc config file put in the same or any parent directory as target markdown source file.

Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that one line, this looks good to me. 👍

let l:pattern = '^ \+\(\d\+\):\(\d\+\) \(warning\|error\) \(.\+\)$'
let l:output = []

call writefile(a:lines, $HOME . '/this_is_test.txt')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You left a test line here.

My recommended way to debug jobs and channels is to use ch_logfile in Vim 8.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, sorry...

@rhysd
Copy link
Contributor Author

rhysd commented Oct 19, 2017

@w0rp I fixed the point 👍

Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this looks good to me. 👍

@w0rp w0rp merged commit 658ec4b into dense-analysis:master Oct 19, 2017
@w0rp
Copy link
Member

w0rp commented Oct 19, 2017

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants