Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around hot-reloading issue again #1745

Merged
merged 1 commit into from Jul 23, 2018
Merged

Work around hot-reloading issue again #1745

merged 1 commit into from Jul 23, 2018

Commits on Jul 23, 2018

  1. Fix autoload for phoenix

    When dializer isn't a dependency, mix dialyzer recompiles the whole
    project because it's not possible to know if this command dialyzer exist
    or not until recompilation is done. Then the timestamps of the project
    is messed up which results in broken hot-loading. In this case, mix help
    dialyzer would return zero which prevents compilation of the whole
    project since dialyzer isn't installed, it's help manual doesn't exist.
    
    When dialyzer is a dependency, mix dialyzer would just run the command.
    In this case, mix help dialyzer would return 1 which allows mix dialyzer
    to run.
    sharils committed Jul 23, 2018
    Copy the full SHA
    e3749c4 View commit details
    Browse the repository at this point in the history