Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change PCRE escape to simple escape #1919

Merged
merged 2 commits into from
Sep 14, 2018
Merged

Change PCRE escape to simple escape #1919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96e25d4
Change PCRE escape to simple escape
saschagrunert Sep 14, 2018
c48106f
Adapt tests
saschagrunert Sep 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ale_linters/go/golangci_lint.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function! ale_linters#go#golangci_lint#GetCommand(buffer) abort

return ale#path#BufferCdString(a:buffer)
\ . '%e run '
\ . ale#util#EscapePCRE(l:filename)
\ . ale#Escape(l:filename)
\ . ' ' . l:options
endfunction

Expand Down
6 changes: 3 additions & 3 deletions test/command_callback/test_golangci_lint_command_callback.vader
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Execute(The golangci-lint defaults should be correct):
AssertLinter 'golangci-lint',
\ 'cd ' . ale#Escape(expand('%:p:h')) . ' && '
\ . ale#Escape('golangci-lint')
\ . ' run ' . ale#util#EscapePCRE(expand('%' . ':t'))
\ . ' run ' . ale#Escape(expand('%' . ':t'))
\ . ' --enable-all'

Execute(The golangci-lint callback should use a configured executable):
Expand All @@ -18,7 +18,7 @@ Execute(The golangci-lint callback should use a configured executable):
AssertLinter 'something else',
\ 'cd ' . ale#Escape(expand('%:p:h')) . ' && '
\ . ale#Escape('something else')
\ . ' run ' . ale#util#EscapePCRE(expand('%' . ':t'))
\ . ' run ' . ale#Escape(expand('%' . ':t'))
\ . ' --enable-all'

Execute(The golangci-lint callback should use configured options):
Expand All @@ -27,7 +27,7 @@ Execute(The golangci-lint callback should use configured options):
AssertLinter 'golangci-lint',
\ 'cd ' . ale#Escape(expand('%:p:h')) . ' && '
\ . ale#Escape('golangci-lint')
\ . ' run ' . ale#util#EscapePCRE(expand('%' . ':t'))
\ . ' run ' . ale#Escape(expand('%' . ':t'))
\ . ' --foobar'

Execute(The golangci-lint `lint_package` option should use the correct command):
Expand Down