Add support for black usage with pipenv #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rp
requested changes
Oct 10, 2018
Latest failed segment. |
RyanSquared
previously approved these changes
Oct 25, 2018
w0rp
approved these changes
Oct 25, 2018
w0rp
requested changes
Oct 25, 2018
autoload/ale/fixers/black.vim
Outdated
|
|
||
| let l:options = ale#Var(a:buffer, 'python_black_options') | ||
|
|
||
| return { | ||
| \ 'command': ale#Escape(l:executable) | ||
| \ 'command': ale#Escape(l:executable. l:exec_args) |
There was a problem hiding this comment.
This isn't right. This will produce a command string like "pipenv run black" -. You want something more like "pipenv" run black -. You should move . l:exec_args outside of the ale#Escape call.
| call ale#test#SetFilename('/testplugin/test/python_fixtures/pipenv/whatever.py') | ||
|
|
||
| AssertEqual | ||
| \ {'command': ale#Escape('pipenv run black') . ' -'}, |
There was a problem hiding this comment.
Fix the test here, given the suggestion above.
|
@mdtusz do you mind fixing some things relating to w0rp's review? After that, it should be good to merge. |
|
Sorry for the radio silence! Will try to get around to it this week to close it up! |
Added ability to set `python_black_auto_pipenv` to allow for usage of a local pipenv black executable.
|
Sorry for the extreme delays! I've fixed up the tests, but vimscript/vader is far out of my normal wheelhouse so let me know if anything looks suspect. |
w0rp
approved these changes
Jan 3, 2019
|
Cheers! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For many projects and just out of habit, I have black installed using pipenv - the standard black executable will work assuming
pipenv shellhas been run before opening vim, but I often forget or haven't run it.This adds support for
blackusage withpipenvthe same way that it works withmypyand other python tools.