Add jshint linter #2
Conversation
|
|
||
| call ALEAddLinter('javascript', { | ||
| \ 'executable': 'jshint', | ||
| \ 'command': 'jshint --reporter unix --config ' . g:ale_jshint_config_loc . ' -', |
There was a problem hiding this comment.
You should use a default for the config location or make the config option in some way. I now offer a command_callback option which lets you generate the command string which will be run in a job. The function takes a buffer number as its only argument. You can look at the shell linter I just added around an hour ago for an example of its use.
Thank you for adding more tools! You contribution is much appreciated. I need to add an option for selecting which linters you want, which is part of why I now require a 'name' option in the dictionary here for identifying which linter it is for which filetype. I'll add that once my RSI clears up. I've been having some issues recently.
There was a problem hiding this comment.
Sorry - I forgot to include plugin/ale/aaflags.vim in this commit. Force pushed an update. Let me know if you like it.
Thank you for writing this! I've been using it all day.. it's very useful and speedy.
There was a problem hiding this comment.
No problem. I'll keep adding more to it especially after I am able to recover from some recent RSI issues I have been experiencing.
|
One thing I'm wondering about is that I might make all of the linters change directory through some means to the directory of the file before running, to make sure they search up parent directories to find a configuration file. A good default for JSHint might be to not specify any configuration files at all in the command, and let JSHint look up parent directories to find one. That's what I used to do with JSHint before I switched to eslint. I think it works in Vim for me at the moment because I separately change directories automatically when I can. |
ckyrouac
force-pushed
the
jshint-linter
branch
from
1a7019d
to
80d99b5
Compare
| " Set this to the location of the jshint configuration file | ||
| if !exists('g:ale_jshint_config_loc') | ||
| let g:ale_jshint_config_loc = '.jshintrc' | ||
| endif |
There was a problem hiding this comment.
Oh sorry, I only just saw this now. This conflicts with some recent changes I did. Check my comments about reading from parent directories as default. I would maybe move this flag into the linter file itself, and keep only the options which apply to all linters in this file.
|
Looking up a config recursively sounds cool. JSHint is a little annoying because it doesn't look for a default configuration file when in stdin mode. That's why I added the flag. I'll clean it up more tonight. |
|
Ah, I see. That sounds unfortunate. I might look into always somehow changing directories when running jobs, maybe something like |
|
You could also write the "search up parent directories" part yourself, as you can now write callbacks for the command to run which will let you do that, if you look at what |
ckyrouac
force-pushed
the
jshint-linter
branch
2 times, most recently
from
81bad73
to
071c5c4
Compare
|
I force pushed the change to move the jshint_config_loc flag to the jshint.vim file. |
ckyrouac
force-pushed
the
jshint-linter
branch
from
91e086b
to
240ce7f
Compare
|
I'll take this as it is for now. If you or others want to improve it, they can go ahead and do that. I'll write that function for finding files in parent directories at some point soon. |
* enable using cpplint for c * fix tag alignment * fix tag alignment trial #2 Co-authored-by: Justin Huang <justin.huang@perceive.io>
No description provided.