Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bibclean fixer support #2061

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Add bibclean fixer support #2061

merged 1 commit into from
Dec 6, 2018

Conversation

hsanson
Copy link
Contributor

@hsanson hsanson commented Nov 7, 2018 •
edited

Adds support for bibclean linter and fixer to ALE.

@hsanson hsanson force-pushed the 1910-add-support-for-bibclean-fixer branch 3 times, most recently from 840b2aa to c6f3332 Compare November 8, 2018 05:34
@hsanson hsanson changed the title WIP Add bibclean fixer support Add bibclean fixer support Nov 8, 2018
@hsanson hsanson force-pushed the 1910-add-support-for-bibclean-fixer branch from c6f3332 to c71aebf Compare November 8, 2018 05:54
w0rp
w0rp requested changes Nov 11, 2018
View reviewed changes
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests for the error parsing in the test/handler directory. This output looks harder to handle.

test/command_callback/bib_paths/dummy.bib Outdated Show resolved Hide resolved
@hsanson hsanson force-pushed the 1910-add-support-for-bibclean-fixer branch from c71aebf to 130f7e3 Compare November 12, 2018 02:33
@hsanson
Copy link
Contributor Author

hsanson commented Nov 12, 2018

@w0rp added handler test as requested.

w0rp
w0rp previously requested changes Nov 12, 2018
View reviewed changes
ale_linters/bib/bibclean.vim Outdated Show resolved Hide resolved
RyanSquared
RyanSquared reviewed Dec 1, 2018
View reviewed changes
doc/ale.txt Outdated Show resolved Hide resolved
@hsanson hsanson force-pushed the 1910-add-support-for-bibclean-fixer branch from c48a3c5 to 9e97a69 Compare December 1, 2018 06:05
@w0rp w0rp merged commit 3db564f into dense-analysis:master Dec 6, 2018
@w0rp
Copy link
Member

w0rp commented Dec 6, 2018

Cheers! 🍻

@hsanson hsanson mentioned this pull request Dec 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanSquared RyanSquared RyanSquared left review comments

@w0rp w0rp w0rp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hsanson @w0rp @RyanSquared