Add versions of ALEGoToDefinition that open in splits #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rp
requested changes
Dec 16, 2018
benjaminjkraft
force-pushed
the
master
branch
from
06e3138
to
5ad7e9e
Compare
|
Looks good. 👍 Don't forget to update the tests too. |
This is just like `:ALEGoToDefinitionInTab`, only a (v)split instead of a tab. Fixes dense-analysis#2140.
benjaminjkraft
force-pushed
the
master
branch
from
5ad7e9e
to
73a204d
Compare
|
Oops! Knew I was forgetting something. |
w0rp
approved these changes
Dec 20, 2018
|
Cheers! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just like
:ALEGoToDefinitionInTab, only a (v)split instead of a tab. Fixes #2140.