Racket linting using raco #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rp
requested changes
Dec 16, 2018
anthonyquizon
commented
Dec 21, 2018
| call ale#assert#TearDownLinterTest() | ||
|
|
||
| Execute(The default command and executable should be correct): | ||
| AssertLinter 'raco', 'raco expand %s' |
There was a problem hiding this comment.
I initially just plugged my code from what was in the docs. However, the ale#Escape function wasn't working for me.
I assumed that this was because I was calling raco expand %s directly in ale#linter#Define under "command".
Execute(The default command should be correct):
" AssertLinter checks the executable and command.
" Pass expected_executable, expected_command
AssertLinter 'some-command', ale#Escape('some-command') . ' --foo'
There was a problem hiding this comment.
ale#Escape is used for a single file, not multiple separate arguments. In this case, it would be ale#Escape("raco")
There was a problem hiding this comment.
Yeah I tried that first.
AssertLinter 'raco', ale#Escape('raco') . ' expand %s'
Unfortunately, that gives me an error. Is there something I'm doing wrong?
Starting Vader: /testplugin/test/command_callback/test_racket_raco_command_callback.vader
(1/1) [EXECUTE] The default command and executable should be correct
(1/1) [EXECUTE] (X) ['raco', 'raco expand %s'] should be equal to ['raco', '''raco'' expand %s']
w0rp
requested changes
Jan 3, 2019
Co-Authored-By: aqui18 <aqui18@users.noreply.github.com>
|
Ok I've reverted the test back to |
w0rp
approved these changes
Jan 14, 2019
|
Cheers! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple 'linter' that uses the same approach as neomake using
raco expandand regular expressions to match output.Will probably look into racket language server in the future.