Add support for bingo #2165
Merged
Add support for bingo #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremija
added a commit
to jeremija/dotfiles
that referenced
this pull request
Dec 27, 2018
We use Languaga Server Protocol support provided by w0rp/ale. The dependencies are: -- JavaScript & TypeScript -- Run "npm install tsserver --save-dev" for any TypeScript or JavaScript project and that should be it. Additionally, tslint and eslint can be used, respectively. -- Golang -- Added pull request for ale: dense-analysis/ale#2165 git clone https://github.com/saibing/bingo.git cd bingo go build # or goinstall Make sure `bingo` is available in your PATH, or edit the `g:ale_go_bingo_executable` variable in vimrc. -- Kotlin -- git clone https://github.com/fwcd/KotlinLanguageServer cd KotlinLanguageServer ./gradlew build -x test Make sure `kotlin-language-server` is available in your path. The shell script you'll be looking for is: `build/install/kotlin-language-server/bin/kotlin-language-server`. Alternatively, you can edit the `g:ale_kotlin_languageserver_executable` in `01-plugins.vim`.
w0rp
requested changes
Jan 5, 2019
ale_linters/go/bingo.vim
Outdated
| let l:options = filter(split(l:options, ' '), 'empty(v:val) != 1') | ||
| let l:command = join(extend(l:executable, l:options), ' ') | ||
|
|
||
| return l:command |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
w0rp
approved these changes
Jan 5, 2019
|
Thanks, @w0rp! |
|
Cheers! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bingo is a fork of go-langserver, and the authors of
go-langserverrecommend to usebingoinstead:There doesn't seem to be any mention of
bingoin the issues except in #2112. I was not able to makebingowork by modifyinggo_langserver_executableandgo_langserver_optionsbecause:ale_go_langserver_optionsbecome sorted and when I try to specify--mode stdio --logfile /tmp/lspserver.log --traceit ends up being something like--mode --logfile --trace /tmp/lspserver.log stdio.ale#go#FindProjectRootusesGOPATHto detect project root. I would always get an error:from this line in bingo source.
I ended up resolving the issue by detecting the
.gitfolder similar toale_linters/php/langserver.vim:I am not sure if this is the best solution since I haven't been actively using Go, but it seems to be working for me.
Would appreciate any feedback!