Manually trigger autocomplete even when prefix is "" #2189
Conversation
jeremija
force-pushed
the
jeremija/manual-autocomplete-wo-prefix
branch
from
07f7ca4
to
9bcf8a2
Compare
autoload/ale/completion.vim
Outdated
| endfunction | ||
|
|
||
| " This function can be used to manually trigger autocomplete, even when | ||
| " g:ale_completion_enabled is set to false | ||
| function! ale#completion#AlwaysGetCompletions() abort | ||
| function! ale#completion#AlwaysGetCompletions(...) abort |
There was a problem hiding this comment.
This function isn't part of ALE's public API, so just add a new argument here and update the command. This is why I asked for the command to be part of the public API, but not the function. 😉
autoload/ale/completion.vim
Outdated
| @@ -106,7 +106,7 @@ function! ale#completion#Filter(buffer, filetype, suggestions, prefix) abort | |||
| " foo. | |||
| " ^ | |||
| " We need to include all of the given suggestions. | |||
| if index(l:triggers, a:prefix) >= 0 | |||
| if index(l:triggers, a:prefix) >= 0 || empty(a:prefix) | |||
There was a problem hiding this comment.
Instead of writing this here, move if empty(a:prefix) to the top of the function, before l:triggers is loaded, and return a:suggestions right away. That will be more efficient when there's no prefix.
There was a problem hiding this comment.
In GetTriggerCharacter above, you should probably add if empty(a:prefix) ... return '' to the top of the function, to avoid processing we don't need again.
There was a problem hiding this comment.
Ah, I said return a:suggestions right away. What I should say is set the variable right away without the other processing above. The suggestions still need to be filtered below, as some LSP configurations have filters in Vim for removing noise.
There was a problem hiding this comment.
Add a test which ensures that filtering on suggestions for Python still works when there's no prefix.
There was a problem hiding this comment.
Roger! When you say:
The suggestions still need to be filtered below, as some LSP configurations have filters in Vim for removing noise.
are you referring to the block starting with if !empty(l:excluded_words)?
There was a problem hiding this comment.
Add a test which ensures that filtering on suggestions for Python still works when there's no prefix.
Do you think the test I added to test_completion_filtering.vader is enough?
AssertEqual
\ ['Deutsch'],
\ ale#completion#Filter(bufnr(''), '', ['Deutsch'], '')There was a problem hiding this comment.
Yes, we the function shouldn't return early, I realised, and should continue down to the part for processing filtering with functions. Look through the tests and make sure that we have a test for the Python language server filtering function which still filters the results when the prefix is empty.
|
Cheers! 🍻 |
|
Thanks! |
This is also related to #1830. Adds a fix for the following scenario:
Previously, the manual completion would not be triggered when the prefix was empty.