-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add textlint for Asciidoc and add it to Fixers #2193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tests for the linter here. See #2190.
Add tests for the fixer function. See :help ale-development
for documentation on developing and testing ALE code.
I got it. However, I think you don't need tests for the linter because the tests are in this repository as for markdown. For example, A linter Should I add just the tests for fixer function? |
I added them. |
Add tests for the linter. You need to use the |
Perhaps, you say I should add test about AsciiDoc in textlint, but I said write-good and proselint just test only one filetype, they don't test about AsciiDoc.
Okay I'll try. |
I'm appriciate you to tell me again, I got what you say. I added it, Please check it, |
Cheers! 🍻 |
I made this patch to run textlint at asciidoc too, and also to work
textlint --fix
inALEFix
.Thank you!