Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add textlint for Asciidoc and add it to Fixers #2193

Merged
merged 7 commits into from
Jan 10, 2019
Merged

Add textlint for Asciidoc and add it to Fixers #2193

merged 7 commits into from
Jan 10, 2019

Conversation

tani
Copy link
Contributor

@tani tani commented Jan 9, 2019

I made this patch to run textlint at asciidoc too, and also to work textlint --fix in ALEFix.
Thank you!

Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests for the linter here. See #2190.

Add tests for the fixer function. See :help ale-development for documentation on developing and testing ALE code.

@tani
Copy link
Contributor Author

tani commented Jan 9, 2019

I got it. However, I think you don't need tests for the linter because the tests are in this repository as for markdown. For example, A linter write-good have just one test for only markdown but write-good covers asciidoc too.

Should I add just the tests for fixer function?

@tani
Copy link
Contributor Author

tani commented Jan 9, 2019

I added them.

@w0rp
Copy link
Member

w0rp commented Jan 10, 2019

Add tests for the linter. You need to use the AssertLinter command. See similar comments in #2190.

@tani
Copy link
Contributor Author

tani commented Jan 10, 2019

I say again, you have already the tests, see https://github.com/w0rp/ale/blob/master/test/command_callback/test_textlint_command_callbacks.vader

Perhaps, you say I should add test about AsciiDoc in textlint, but I said write-good and proselint just test only one filetype, they don't test about AsciiDoc.

Therefore I think you can merge this requrest,

Okay I'll try.

@tani
Copy link
Contributor Author

tani commented Jan 10, 2019

I'm appriciate you to tell me again, I got what you say. I added it, Please check it,

@w0rp w0rp merged commit fabebb3 into dense-analysis:master Jan 10, 2019
@w0rp
Copy link
Member

w0rp commented Jan 10, 2019

Cheers! 🍻

@tani tani mentioned this pull request Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants