make options for credo configurable #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 6, 2019 16:38
If a user sets 'let g:ale_elixir_credo_strict=1' it will run credo with --strict instead of suggest. The defaul t(0) is to run as suggest.
|
Fixed the issue. @w0rp please let me now if you require any changes. |
w0rp
changed the title
w0rp
requested changes
Mar 8, 2019
added 8 commits
March 9, 2019 11:13
…e CI server for 'cd /d && mix...'
Went back to ':help ale-testing' and found that I can run ./run_test <filename> which helped pinpoint the issue with my vader test. Needed to set the filename for the a mix project which already existed in the test data. Also used the ale#path#Simply function to get the correct directory of where the command would be executed.
… negates my /d issue.
w0rp
approved these changes
Mar 11, 2019
|
Cheers! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add credo --strict option
If a user sets 'let g:ale_elixir_credo_strict=1' it will run credo with --strict instead of suggest. The default (0) is to run as suggest.
ToC and doc file updated however I can't seem to get the tests to pass for the ToC, not sure what I am doing wrong. Any help would be appreciated.
Closes #2335