make gotype return all errors
#2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rp
requested changes
Mar 7, 2019
When using `gotype` without the `-e` option, it will only output the first 10 errors. When working on a larger package that ofter means taht those 10 errors are in other files then the one that you are currently working on which then seems to indicate that there are no errors. By adding the `-e` flag, all errors will be returned and shown properly in the file that you are working on.
|
@w0rp just updated the tests to match the updated command. Sorry for the delay on that! |
w0rp
approved these changes
Apr 2, 2019
|
Cheers! 🍻 Sorry for the delay. I was busy and on holiday. |
|
No worries! Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
gotypewithout the-eoption, it will only output the first 10 errors. When working on a larger package that often means that those 10 errors are in other files then the one that you are currently working on which then seems to indicate that there are no errors.By adding the
-eflag, all errors will be returned and shown properly in the file that you are working on.