Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support jsonlint local executable #2363

Merged
merged 1 commit into from
Mar 25, 2019
Merged

support jsonlint local executable #2363

merged 1 commit into from
Mar 25, 2019
+81 −4

Conversation

davidsierradz
Copy link
Contributor

This is a very basic change, should I write tests for it?

w0rp
w0rp requested changes Mar 15, 2019
View reviewed changes
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, add a test like the node_modules test for eslint. Remember to add empty dotfiles with git add -f, as they are ignored by default.

@davidsierradz
Copy link
Contributor Author

Done, let me know if this is ok.

@w0rp w0rp merged commit 32c8bd1 into dense-analysis:master Mar 25, 2019
@w0rp
Copy link
Member

w0rp commented Mar 25, 2019

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w0rp w0rp w0rp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidsierradz @w0rp