Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy: try to find folder containing mypy.ini to use as cwd. #2385

Merged
merged 4 commits into from
Jan 2, 2020

Conversation

hjwp
Copy link
Contributor

@hjwp hjwp commented Mar 22, 2019

attempts to fix #2383

no tests i'm afraid (yet? will see what i can do. i don't know vimscript...)

Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just needs a test, and ale#path#FindNearestFile can be used to find the file instead.

@w0rp w0rp added this to In Review in Old Working List via automation Apr 10, 2019
@w0rp w0rp added this to In Review in On the Radar Aug 17, 2019
@johnor
Copy link

johnor commented Oct 31, 2019

@hjwp Are you going to continue to work on this PR? I have tested it and it solves #2383. Would be great if we could get it merged.

@hjwp
Copy link
Contributor Author

hjwp commented Nov 1, 2019

ok, am giving it a go now.

@hjwp
Copy link
Contributor Author

hjwp commented Nov 1, 2019

OK i think the test work. I couldn't figure out how to use ale#path#FindNearestFile, or at least, i tried using it, but i couldn't figure out how to derive the containing folder, given a full path to a file. But what we have now works...

Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, and sorry for the delay. I'll merge this now.

@w0rp w0rp merged commit 72d2c55 into dense-analysis:master Jan 2, 2020
On the Radar automation moved this from In Review to Done Jan 2, 2020
@hjwp
Copy link
Contributor Author

hjwp commented Jan 2, 2020

🎉 hooray! and no need to apologise. happy new year!

anupdhml pushed a commit to anupdhml/ale that referenced this pull request Feb 4, 2020
…alysis#2385)

* When deciding which directory to run mypy from, prefer a folder with mypy.ini in it
* Add a test for mypy.ini-finding behaviour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Mypy plugin does not choose correct cwd
3 participants