feat: fecs support for js/html/css lint and format #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rp
requested changes
Apr 10, 2019
There was a problem hiding this comment.
I finally had a chance to look at this. Looks pretty good to me. Add some tests for the linter and fixer commands. See :help ale-tests and existing test files. You will probably have to configure the fixer to use something executable to get the command out in tests.
doc/ale.txt
Outdated
| @@ -49,6 +49,7 @@ ALE supports the following key features for linting: | |||
| 6. Using |echo| to show error messages when the cursor moves. | |||
| 7. Setting syntax highlights for errors. | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
You can remove the blank line here.
`fecs` is a lint tool for HTML/CSS/JavaScript, see http://fecs.baidu.com for more options.
harttle
changed the title
|
Along with |
w0rp
approved these changes
Apr 13, 2019
|
Cheers! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FECS is a lint tool for checking and fixing HTML/CSS/JavaScript code styles. I've been using the modified version locally, it works just fine. But I find that the ale-dev doc says:
I would like to make it public. It's widely used here, hope the following links helpful:
Github: https://github.com/ecomfe/fecs
Wiki: https://github.com/ecomfe/fecs/wiki/CLI
I passed the tests locally but there's some warnings for the document checking, but it seems not related. BTW, thank you guys for this great repo, I migrate from syntastic with no regret.