Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better phpstan default configuration #2444

Merged
merged 3 commits into from
May 1, 2019
Merged

Better phpstan default configuration #2444

merged 3 commits into from
May 1, 2019

Conversation

jdeniau
Copy link
Contributor

@jdeniau jdeniau commented Apr 17, 2019 •
edited

  • If a config file is found, then do not set the default level to 4, the level should be in the configuration file (except if you force it of course).
  • Mark phpstan error as error, not warning, as phpstan does not have warning, only errors.
  • Use the --no-progress parameter

Thank you !

@jdeniau jdeniau changed the title Use phpstan config file as default whenever possible + report as error Better phpstan default configuration Apr 17, 2019
w0rp
w0rp requested changes Apr 17, 2019
View reviewed changes
test/handler/test_phpstan_handler.vader Outdated Show resolved Hide resolved
ale_linters/php/phpstan.vim Outdated Show resolved Hide resolved
@w0rp w0rp added this to In Review in Old Working List via automation Apr 17, 2019
@jdeniau
Copy link
Contributor Author

jdeniau commented Apr 19, 2019

@w0rp changes made

@w0rp w0rp merged commit c6aae3b into dense-analysis:master May 1, 2019
Old Working List automation moved this from In Review to Done May 1, 2019
@w0rp
Copy link
Member

w0rp commented May 1, 2019

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w0rp w0rp w0rp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jdeniau @w0rp