Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to show msg id when pylint is used #2445

Merged
merged 3 commits into from
May 9, 2019

Conversation

katsuya-horiuchi
Copy link
Contributor

@katsuya-horiuchi katsuya-horiuchi commented Apr 18, 2019

With this change, let g:ale_python_pylint_use_msg_id = 1 can be used to tweak the output of pylint.

This would allow you to show message id instead of human-friendly format (See #852 for discussion).

I've never written vimscript before and basically have no idea what I'm doing, so couldn't write test.
I'd appreciate it if someone can add a test for this.

Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at :help ale-tests, and the existing pylint test file. You can add a test for this there. Make sure to Save and Restore the setting so the value is reset after each test.

@w0rp w0rp added this to In Review in Old Working List via automation May 1, 2019
@katsuya-horiuchi
Copy link
Contributor Author

Sorry to have taken some time. Could you check the test I've added?

@w0rp w0rp merged commit f444abd into dense-analysis:master May 9, 2019
Old Working List automation moved this from In Review to Done May 9, 2019
@w0rp
Copy link
Member

w0rp commented May 9, 2019

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants