Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phpstan autoload option #2491

Merged
merged 2 commits into from
May 12, 2019
Merged

Add phpstan autoload option #2491

merged 2 commits into from
May 12, 2019

Conversation

mpesari
Copy link
Contributor

@mpesari mpesari commented May 10, 2019

This PR adds the -a option to ale's phpstan call. I used to let g:ale_php_phpstan_configuration = 'phpstan.neon -a autoload.php', but that was broken recently in commit 5f64f8d due to option escaping. So I just added this option and it works for me.

I could probably write a simple test to verify that the option is used, but not sure if it's necessary. What do you think?

Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, add a test for this.

@w0rp w0rp added the fix tests label May 11, 2019
@w0rp w0rp merged commit aa047b5 into dense-analysis:master May 12, 2019
@w0rp
Copy link
Member

w0rp commented May 12, 2019

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants