WIP: Add cppcheck includes when modified buffer or no compile_commands.json

[ckoehler]

This can probably be expanded to look at -I directives from compile_commands.json to make it more robust. See comments in the code.

I don't know how to modify a buffer from a Vader Execute block, so those tests are failing right now. You may have a better idea.

[w0rp]

You can use :set modified to mark a buffer as modified.

Is there any danger in always setting -I with the directory name? Does it make the results less accurate? If so, your solution is a good one. Paired with the code I had for improving how compile_commands.json files are found, this should be good.

[ckoehler]

I'm not sure it'd make a difference. I think cppcheck just ignores -I when --project is given.
Doing a :set modified or set modified does not seem to work in the test...

[ckoehler]

Actually, after setting modified, do I need to call ALE again? I've tried

set modified
ALELint

and

set modified
call ale#Queue(0)

but neither seem to work. I'd appreciate the help, if you want that last test. I don't have time to pursue this much further.
Let me know if you figure it out, or whether I can just remove the last test. I'll then clean up the pull request.

[w0rp]

The duplicate code can be written in one function here. If you can get the tests to work, let me know. If not, I or someone else might pick this up later.

[ckoehler]

I escaped the paths.

Can you clarify what you think should be a separate function, and where it should live?

[w0rp]

You can create a function in autoload/ale/handlers/cppcheck.vim that both versions of the linter can use. Make sure to update the code here to take the recent changes I've made for using build/compile_commands.json into account.

[ckoehler]

Alright, refactored, and all but that one test (where I set modified) pass. I don't know enough about Vader to figure this one out, so I'll leave it up to you from here. Thanks!

[w0rp]

@bartlibert Does this look okay to you?

[bartlibert]

Looks fine to me. Nice improvement.

[w0rp]

I fixed the test and merged this via the commandline now.