Fix eclipselsp workspace config #2520
Conversation
|
@hsanson Thank you so much for this. I have spent hours and hours trying to figure out what was wrong with my setup and after I posted this you came up with a solution right away. Just tested pulling these changes and opening up a Java+Gradle project and can confirm Gradle gets triggered, the dependencies get downloaded and third-party libraries now have auto-completion and hover support. Keep up the good work! |
|
You'll have to rebase this now. While you're at it, add |
We were setting the -data parameter to the project root but this caused the language server to fail initialization and synch of gradle dependencies. As consequence ALE failed to work fully on gradle projects. This fix sets the workspace to the parent folder of the project root. Normally this corresponds to the correct Eclipse workspace path. When this is not the case, this fix also allows users to explicitly set the absolute path to the workspace via configuration variable.
hsanson
force-pushed
the
fix-eclipselsp-workspace-config
branch
from
d6c3340
to
5a8ba75
Compare
|
@GrimKriegor thanks for reporting. This allows me to find out issues that require attention. |
|
@w0rp rebased and added ale#Escape() to all paths in the command. |
|
I'll merge this, though I have a question. If the workspace path is empty, and we pass |
|
Cheers! 🍻 |
Fixes command line used to start eclipselsp to set workspace correctly. Also adds a conf variable to set a specific eclipse workspace path.
Fixes #2519