languagetools: stop auto-appending --autoDetect #2616
Conversation
There was a problem hiding this comment.
I think the best way to handle this is to add a new _options variable where the default contains this option. That way nothing will change for people who currently rely on this option, and anyone who doesn't want the option can remove it in their vimrc file. Have a look at other linters for examples and examples of tests for options.
|
@w0rp the _options variable has been created. I've updated the tests and the docs accordingly. Please let me know if there's anything else required. |
|
I don't use ngrams but experiencing issue with --autoDetect resulting in the following output:
Changing '--autoDetect' to -'-language en-GB' in the handler fixes the issue. |
|
It seems that In the meanwhile, you could work around this issue by my simple plug-in (together with, say, vim-dispatch to run the LanguageTool grammar check in the background) where all parameters passed can be entirely overridden. |
@w0rp it seems like the comments in this thread are pointing out that --autoDetect may be a bad default. That said, this PR makes it easily override-able. If there is nothing else to do, would we be able to merge this soon? I'd like to stop using my personal fork for daily work, if possible. |
Auto-appending anything to the command is a problem because it prevents
users from overriding the appended configuration. There was no way to
remove --autoDetect from the executed command without this commit /
updating the plugin source code.
In this particular instance, --autoDetect conflicts with a local
command line usage of languagetools with the ngram data installed
locally.
Example command (in a bashscript in my path called languagetools):
#!/bin/bash
java -jar ~/java/LanguageTool-4.5/languagetool-commandline.jar \
--languagemodel $HOME/Data/ngrams \
${@}
By placing "--autoDetect" before my filename, languagetools would only
return linting messages unassociated with ngrams (which are necessary
for checking "their" versus "there" errors). Once I manually removed
this line, everything works correctly.
Enables overriding the options passed to the languagetools binary. This enables users to override "--autoDetect" while preserving the old behavior.
pappasam
force-pushed
the
languagetool_autodetect_breaks_ngrams
branch
from
1c85e2e
to
68da041
Compare
Options are now configurable for languagetools, and `--autoDetect` can be removed by changing the options.
This pull request fixes an issue where Ale prevents the user from overriding a broken setting in languagetools (--autoDetect). --autoDetect conflicts with a local
command line usage of languagetools with the ngram data installed
locally. In my case, I've downloaded "en" ngrams with support for the English language.
If you want to retain current behavior, you can change the default value for the languagetools command. That said, since it appears to be somewhat broken, it's probably better to just default to languagetools with no options (as this PR currently implements).
Design-wise, auto-appending anything to a command is a problem because it prevents
users from overriding the appended configuration. There was no way to
remove --autoDetect from the executed command without this commit /
updating the plugin source code. If a user wants autoDetect they are free to place it in their bash script (or other path-included script).
Example command (in a bashscript in my path called languagetools):
By placing "--autoDetect" before my filename, languagetools would only
return linting messages unassociated with ngrams (which are necessary
for checking "their" versus "there" errors). Once I manually removed
this line, everything works correctly.
Example with ngrams and NO autoDetect
notice the second suggestion for "their" versus "there"
Example with ngrams and autoDetect
notice there is only 1 suggestion