New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust cargo linter to better integrate with Clippy #2618

Merged

w0rp merged 2 commits into dense-analysis:master from rustic-games:clippy-flags

Jul 14, 2019

Contributor

JeanMertz commented Jun 24, 2019

Two changes:

It was confusing (and not mentioned in the documentation) that rust_cargo_clippy_options required you to start the string with -- (such as -- -D warning). It now accepts both forms (so also -D warning).
For some reason (AFAIK incorrectly) all cargo-specific flags were only supported for cargo check, while these are also valid for cargo build and cargo clippy. This now works as expected.

Aside from the unit tests, I tested both changes in my local Rust project, and they worked as expected.

JeanMertz added 2 commits

June 24, 2019 19:47


          support clippy options with --

e52388b


          support all cargo options for build/clippy

53b0e6c

JeanMertz force-pushed the clippy-flags branch from 9e1c521 to 53b0e6c Compare

June 25, 2019 09:22

w0rp approved these changes

View reviewed changes

w0rp merged commit aae6d30 into dense-analysis:master

Member

w0rp commented Jul 14, 2019

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment