Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elm language server params update #2750

Conversation

andys8
Copy link
Contributor

@andys8 andys8 commented Sep 3, 2019

Changes

  • There is a new param 'elmAnalyseTrigger' (change|save|never)
  • Empty path default to let the language server search for binary

Note

Although --stdio argument is now default, it'll still be passed for compatibility with people using older version of the language server,

Settings documentation

https://github.com/elm-tooling/elm-language-server#server-settings

* There is a new param 'elmAnalyseTrigger' (change|save|never)
* Empty path default to let the language server search for binary
@andys8 andys8 force-pushed the improvement/elm-language-server-elm-analyse-trigger-param branch from 2df47e2 to bd1f7e1 Compare September 3, 2019 22:20
@andys8 andys8 marked this pull request as ready for review September 5, 2019 13:09
@andys8
Copy link
Contributor Author

andys8 commented Sep 5, 2019

Tested it and it works fine with @elm-tooling/elm-language-server@1.4.0.

BrianHicks added a commit to BrianHicks/dotfiles.nix that referenced this pull request Sep 6, 2019
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this code work with the older version of the language server too?

@andys8
Copy link
Contributor Author

andys8 commented Sep 22, 2019

elm-language-server itself is still in early active development. So using older versions isn't encouraged.

The changes should be compatible, though.

Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, if the language server is still very early in development, it's okay to update this.

@w0rp w0rp merged commit 8097d51 into dense-analysis:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants