credo now recognizes umbrella projects #2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ale#handlers#elixir#FindMixUmbrellaRoot to determine project root instead of ale#handlers#elixir#FindMixProjectRoot
|
@w0rp Is there anything missing on this PR that's a reason for neither approving nor rejecting it? |
|
+1, I need this. I had to monkey patch this function in my .vimrc |
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
w0rp
approved these changes
Aug 17, 2020
|
Cheers! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ale#handlers#elixir#FindMixUmbrellaRoot to determine project root
instead of ale#handlers#elixir#FindMixProjectRoot
Updated tests so they check both reguler and umbrella project compatibility.