Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2777 - Add IBM openapi validator #2782

Merged
merged 4 commits into from
Jan 22, 2021
Merged

Fix 2777 - Add IBM openapi validator #2782

merged 4 commits into from
Jan 22, 2021

Conversation

hsanson
Copy link
Contributor

@hsanson hsanson commented Sep 20, 2019 •
edited

Adds IBM openapi validator to the ever growing list of ALE linters. This allows us to edit open api specs in yaml within vim/neovim with confidence.

Closes #2777

@hsanson hsanson requested a review from w0rp September 20, 2019 13:05
w0rp
w0rp requested changes Oct 7, 2019
View reviewed changes
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only thing we need to change here is that the linter will run for all YAML files, but should somehow only run for OpenAPI configuration files. Maybe a different filetype can be used.

@hsanson hsanson force-pushed the 2777-add-ibm-openapi-validator branch from 9fb2b6a to 9563fd9 Compare October 26, 2019 14:16
@hsanson
Copy link
Contributor Author

hsanson commented Oct 26, 2019 •
edited

@w0rp I have modified this so it uses a different filetype "openapi". Also modified yamllint so it can be used with openapi files and added prettier as suggested fixer for openapi files.

@hsanson
Copy link
Contributor Author

hsanson commented Nov 28, 2019

@w0rp sorry to push this given so many MRs that still need review but what else would be required to get this merged? I use this frequently at work and would like to have it in master.

@hsanson hsanson mentioned this pull request May 15, 2020
Merged
@stale
Copy link

stale bot commented Aug 13, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Aug 13, 2020
@stale stale bot closed this Aug 15, 2020
@hsanson hsanson reopened this Aug 15, 2020
@stale stale bot removed the stale PRs a bot will close automatically label Aug 15, 2020
@stale
Copy link

stale bot commented Sep 25, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Sep 25, 2020
@hsanson hsanson requested a review from w0rp September 26, 2020 05:52
@stale stale bot removed the stale PRs a bot will close automatically label Sep 26, 2020
@stale
Copy link

stale bot commented Oct 24, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Oct 24, 2020
@stale stale bot closed this Oct 31, 2020
@hsanson hsanson reopened this Oct 31, 2020
@stale stale bot removed the stale PRs a bot will close automatically label Oct 31, 2020
@stale
Copy link

stale bot commented Nov 28, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Nov 28, 2020
@hsanson
Copy link
Contributor Author

hsanson commented Nov 29, 2020

Not stale, waiting review and merge.

@stale stale bot removed the stale PRs a bot will close automatically label Nov 29, 2020
@stale
Copy link

stale bot commented Dec 27, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Dec 27, 2020
@hsanson hsanson removed the stale PRs a bot will close automatically label Dec 28, 2020
Horacio Sanson and others added 3 commits January 22, 2021 23:17
@hsanson hsanson force-pushed the 2777-add-ibm-openapi-validator branch from ed5171e to 4aa11cb Compare January 22, 2021 14:17
@hsanson hsanson merged commit db816b5 into dense-analysis:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w0rp w0rp Awaiting requested review from w0rp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for IBM openapi validator
2 participants
@hsanson @w0rp