Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Ada Language Server #2825

Merged
merged 40 commits into from
Jan 23, 2021
Merged

Conversation

thindil
Copy link
Contributor

@thindil thindil commented Oct 11, 2019

No description provided.

ale_linters/ada/adalsp.vim Outdated Show resolved Hide resolved
@thindil thindil requested a review from w0rp October 24, 2019 08:27
@timlag1305
Copy link
Contributor

I added inline diffs. I can also give you a patch file later tonight @thindil if that's easier.

thindil and others added 4 commits November 5, 2019 17:58
Co-Authored-By: timlag1305 <timlag1305@gmail.com>
Co-Authored-By: timlag1305 <timlag1305@gmail.com>
Co-Authored-By: timlag1305 <timlag1305@gmail.com>
Co-Authored-By: timlag1305 <timlag1305@gmail.com>
@thindil
Copy link
Contributor Author

thindil commented Nov 5, 2019

I added inline diffs. I can also give you a patch file later tonight @thindil if that's easier.

@timlag1305 thank you very much. I just added them to my fork and I will test them soon. Should be everything ok.

@kalkin
Copy link

kalkin commented Jun 6, 2020

Bump?

@thindil
Copy link
Contributor Author

thindil commented Jun 7, 2020

@kalkin All requested changes are done thus now we just wait :)

@timlag1305
Copy link
Contributor

Yeah unfortunately the original maintainer doesn't really have the time to handle all these PRs. They tried to get others to step up, but I'm not sure how effective that was. I'm sure the project would be receptive if someone was willing to step up. I think in the mean time, if I wanted a specific PR in my version of ale, I would fork the project and roll the PRs into my fork.

@thindil
Copy link
Contributor Author

thindil commented Jun 12, 2020

@timlag1305 true, plus as far I know, my fork should be synced with main repo, thus you can use it instead of official and pokes me about syncing it :)

@hsanson
Copy link
Contributor

hsanson commented Jan 22, 2021

ALE migrated from Travis to Github Actions (see #3548) so it is necessary to rebase this PR from latest master branch to trigger the required checks.

# Add dense-analysis as remote upstream on your local fork. Not 
# needed if already added.
git remote add upstream https://github.com/dense-analysis/ale.git

# Sync your local master with upstream master
git checkout master
git fetch upstream master
git merge upstream/master

# Rebase the PR branch with master
git checkout my-branch-name
git rebase master   # Fix any conflicts you may have

# Force push the updated PR branch to origin to trigger the checks
git push -f origin my-branch-name

@thindil
Copy link
Contributor Author

thindil commented Jan 22, 2021

@hsanson Thank you for pointing me there. The local fork was rebased as requested. Also, requested changes were done (a long time ago). If something other is needed to do here, please tell 😄

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patience. Looks good to me.

@hsanson hsanson merged commit 5200e6c into dense-analysis:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants