-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Ada Language Server #2825
Conversation
…e to adals instead of adalsp
I added inline diffs. I can also give you a patch file later tonight @thindil if that's easier. |
Co-Authored-By: timlag1305 <timlag1305@gmail.com>
Co-Authored-By: timlag1305 <timlag1305@gmail.com>
Co-Authored-By: timlag1305 <timlag1305@gmail.com>
Co-Authored-By: timlag1305 <timlag1305@gmail.com>
@timlag1305 thank you very much. I just added them to my fork and I will test them soon. Should be everything ok. |
Bump? |
@kalkin All requested changes are done thus now we just wait :) |
Yeah unfortunately the original maintainer doesn't really have the time to handle all these PRs. They tried to get others to step up, but I'm not sure how effective that was. I'm sure the project would be receptive if someone was willing to step up. I think in the mean time, if I wanted a specific PR in my version of ale, I would fork the project and roll the PRs into my fork. |
@timlag1305 true, plus as far I know, my fork should be synced with main repo, thus you can use it instead of official and pokes me about syncing it :) |
ALE migrated from Travis to Github Actions (see #3548) so it is necessary to rebase this PR from latest master branch to trigger the required checks.
|
@hsanson Thank you for pointing me there. The local fork was rebased as requested. Also, requested changes were done (a long time ago). If something other is needed to do here, please tell 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patience. Looks good to me.
No description provided.