Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remark-lint for a markdown fixer #2836

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

blyoa
Copy link
Contributor

@blyoa blyoa commented Oct 16, 2019

Closes #1211

This PR added remark-lint for a markdown fixer.

This feature is already reported in #1211, and this PR was based on code proposed by @dirkroorda there.

Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could you document the new options? Sorry for the delay.

@blyoa
Copy link
Contributor Author

blyoa commented Feb 3, 2020

Thank you for the review, and I'm sorry for the delay.
This PR does not introduce any new option and uses the same options of remark-lint for a linter. I referenced options of eslint, which works as both a linter and a fixer, and I did not add any description, but should I add it?

@stale
Copy link

stale bot commented Aug 13, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Aug 13, 2020
@stale stale bot closed this Aug 15, 2020
@dbellavista
Copy link

Hi @w0rp ! I was waiting for this merge request to be completed, I took a look at :help ale-dev but I think everything is in order. The documentation is missing because the tool is already documented and listed as supported, so I can't really find a place where to document this.

If @blyoa is not available to make the required changes I could replicate and fix the merge request

@w0rp w0rp reopened this Aug 17, 2020
@stale stale bot removed the stale PRs a bot will close automatically label Aug 17, 2020
w0rp
w0rp previously approved these changes Aug 17, 2020
@w0rp w0rp merged commit d5c1d84 into dense-analysis:master Aug 17, 2020
@w0rp
Copy link
Member

w0rp commented Aug 17, 2020

Cheers! 🍻

@w0rp
Copy link
Member

w0rp commented Aug 17, 2020

Nevermind the stale bot. I'm actually using it to get pull requests merged faster by automating it poking people for responses and getting some answers back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support fixing code with remark
3 participants