Add support for rust-analyzer

[jonhoo]

Fixes #2832.

This is a very straightforward adaptation of the existing rls support.

[cwndrws]

This looks good, but I have no say. Just came here to make similar changes. Glad this is being done and hope it gets in soon!

[jonhoo]

Thanks! Fix pushed.

[syphar]

@jonhoo thanks for doing this!

[kamek-pf]

@jonhoo I gave your branch a shot, RA seems to run as intended, but I can't get clippy to run.
I tried with let b:ale_rust_analyzer_config = {'rust': {'clippy_preference': 'on'}}
Maybe there's some sort of integration between rust analyzer and clippy to enable somewhere ?

[Arzte]

Heya is there any blockers on merging this?

[jonhoo]

Not on my part. I no longer use ale, but last I checked the patch worked fine :)
I think that this line may need to be updated if the server binary has gotten a new name (which I remember there being some discussion of):

ale/ale_linters/rust/analyzer.vim

Line 4 in 715733f

call ale#Set('rust_analyzer_executable', 'ra_lsp_server')

It'd be good if someone actively using this could try it out and verify 👍

[Arzte]

Applied this patch to my local copy of ale and set it to use rust-analyzer, seems to be working perfectly for me. 👍
EDIT: Looks like it's not working after all, ALEInfo doesn't report analyzer as an enabled linter. I don't know enough about ALE to diagnose why, but I could try if someone has any advice to why it may not be working. (the server name is ra_lsp_server)

[Shadow53]

The upstream binary name for rust-analyzer has been changed to rust-analyzer. That may be why it didn't work for Arzte.

[jonhoo]

@Shadow53 thanks! I've pushed a commit that changes the default.

[Arzte]

Looks like it works now, was able to use rust-analyzer with ale without an issue.

[1wilkens]

Anything blocking this? I would really like to use rust-analyzer "out-of-the-box" with ale :)

[jonhoo]

@1wilkens not as far as I am aware — this is ready to review/merge from my side.

fixed

[RyanSquared]

LGTM.

[RyanSquared]

Cheers! 🍻