-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to customize items #2847
Allow user to customize items #2847
Conversation
@w0rp looks like it's failing on |
The error message printed says there's no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need some tests and a few changes.
@@ -36,23 +36,23 @@ Execute(TypeScript completion details responses should be parsed correctly): | |||
\ 'word': 'abc', | |||
\ 'menu': '(property) Foo.abc: number', | |||
\ 'info': '', | |||
\ 'kind': 'f', | |||
\ 'kind': 'v', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests should still pass, as we should keep the existing defaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to maintain strict backward compatibility?
Seems to me we'd want to make these roughly match the kinds that vim has built in:
v variable
f function or method
m member of a struct or class
t typedef
d #define or macro
In particular, since this is a property
it would probably map best to m
(not v
as it is right now, sorry). Same as the Rust types above. They probably map best to t
, right?
I'm happy to maintain compat though or try this new logical mapping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@w0rp sorry to bug you, but still waiting for a definitive response here :)
da4a24d
to
574824c
Compare
Sorry for the noise. Still having trouble getting I'm not sure what I'm missing here :/ |
c527f59
to
a0f152b
Compare
@w0rp got the linter passing :) Once I get feedback on the completion items, I should be good to go |
AppVeyor issue appears to be caused by |
a0f152b
to
e2a6781
Compare
@w0rp looks like the Thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good as it is. Let's go with this.
Cheers! 🍻 |
Thanks! |
Continues from #2710
Allows the user to set their own completion fields
Relies on #2845