Fix 2891 - eslint not showing errors. #2910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint errors are contained in an array that can contain different stuff other than JSON error messages. This patch iterates over the whole array ignoring any non-json data.
|
Assuming tests pass, LGTM. Edit: This comment only showed up way after tests pass. LGTM. |
|
It looks like #2909 has [the start of] a more general solution, preventing warning output from the tool. |
|
This PR will ignore deprecation warnings no matter if the --no-deprecation flag is used or not when invoking the linter. Since users can change the eslint executable and options using g:ale_javascript_eslint_executable and g:ale_javascript_eslint_options the solution in #2909 may not work for some. |
w0rp
approved these changes
Nov 27, 2019
|
Cheers! 🍻 This will fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint errors are contained in an array that can contain different
stuff other than JSON error messages. This patch iterates over the whole
array ignoring any non-json data.
Fix #2891 for ESLint only.