Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verilog: Add filename to vlog linter output #2924

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

patrick96
Copy link
Contributor

I have customized the options for vlog to lint all my verilog files because files depend on each other. But now the warnings in other files are always displayed in the current buffer.

For that reason I have extended the handler to also match the filename and include it in the output.

./run-tests works fine and it also works in my project now.

@patrick96 patrick96 requested a review from w0rp February 14, 2020 11:11
@stale
Copy link

stale bot commented Aug 13, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Aug 13, 2020
@patrick96
Copy link
Contributor Author

@w0rp Is there anything that I missed in this PR?

@stale stale bot removed the stale PRs a bot will close automatically label Aug 13, 2020
@w0rp w0rp merged commit 94a968e into dense-analysis:master Aug 13, 2020
@w0rp
Copy link
Member

w0rp commented Aug 13, 2020

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants