Add popup support to ALEHover and ALEDetails

[ian-howell]

Addresses #2922.

This causes the behavior of ALEHover and ALEDetails to change when g:ale_set_balloons = 1, causing each command to output information to a balloon rather than using the preview window.

It doesn't appear that the modified functions have tests, and I'm honestly not sure how to go about testing such a change. If anyone has any suggestions, I'll write them.

@dotdash This change is merely a slight change to the patch you proposed in #2922. If you'd like to take ownership of this change, I will gladly abandon this PR.

[dotdash]

Popups are more general and separate from the balloon feature. The feature check needs to check for textprop instead of balloon_eval.

There should probably also be a separate option, since at least I want popups, but no balloons as I find the mouse hover feature rather irritating.

[dotdash]

Hey, thanks for picking this up 👍

I'd rather have you push it across the finish line than take ownership if that's fine with you.

[w0rp]

Using the newer popups if available is a good idea. We need to check if the popup_atcursor function exists, and let's separate the popup usage from the balloons. Let's have some kind of separate option for popups.

[ian-howell]

I'm going to continue working on this when I find some free time. I'm planning on taking an approach similar to the strategy in #2828.

I'll squash all the commits when I'm finished.

[ian-howell]

@w0rp I've added the g:ale_hover_to_popup option as well as various functionality checks.

I know that #2828 is very much fresh off the burner, but I think it may be a good idea to merge g:ale_hover_to_popup and g:ale_hover_to_preview to a single string value, perhaps g:ale_hover_window_type. That would reduce the complexity of having one option override the other.

Otherwise, this PR should be good to go - I just need to squash and clean up the PR and commit messages.

Let me know your thoughts.

[sbromberger]

Is there any chance this might be merged soon? I'd really like to use popups instead of the preview window. Thanks.

[ilya-m32]

Hi! First of all, thanks to @ian-howell for this awesome feature. I've tried this branch locally and it looks very promising.

Is there anything blocking this PR from being merged to master? If yes, I'd like to help to speed things up (if possible). Right now PR looks abandoned without a reason.

[dotdash]

@ian-howell since this actually good to go, it might be a good idea to remove the WIP prefix and then ping the maintainer(s?) again

[ian-howell]

@w0rp This should be ready to go

[ilya-m32]

@w0rp can you take a look please? Is there something left to accept the PR?

[w0rp]

Let's remove this setting and add a separate setting for showing :ALEDetail messages in popups, and let's turn it off by default. Most of the text I look at for details will fill the screen horizontally.

Update the documentation for g:ale_cursor_detail to mention the popup behaviour. It mentions only the preview-window at the moment.

It might be easier if you split your pull request into two parts. First add popup support for hover, and then add popup support for detailed messages for problems.

[w0rp]

I'm interested in adding popup support for mouseover hovers, which could be the default. I think :ALEDetail should still default to the preview window. I also want to add support for handling markdown and converting it into Vim syntax highlighting inside of the popups.

[stale]

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

[tribou]

@w0rp should this be reopened or does the work need to continue somewhere else? I'd love to see pop-ups in ALE as well!

[w0rp]

I'd like to see a new pull request which implements just one of these two uses of popups with tests. I recall from reading this that one part was mostly good, but I wasn't sure about the other part.