Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sql-lint as linter #2988

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Add sql-lint as linter #2988

merged 1 commit into from
Aug 28, 2020

Conversation

joereynolds
Copy link
Contributor

@joereynolds joereynolds commented Jan 31, 2020

Hey,
This adds support for the sql-linter sql-lint.

There was a previous pr however I'm closing it as the branch had gone away as I did some cleaning of my laptop/github.

I've addressed the comments that were posted on there.

  • Tests have been added
  • The linter is no longer MySQL specific so the other comment about detecting if it's MySQL only is no longer valid

Thanks!

@joereynolds
Copy link
Contributor Author

Hey @w0rp I saw your comment on Reddit about pinging for your attention so I'm doing that (though I do feel cheeky).

Hope the PR is okay!

@joereynolds
Copy link
Contributor Author

Hey, is there an update on this? I've been working off my own fork of Ale because this is still yet to be merged in.
Thanks!

@reelbeelveel
Copy link

Any update? I would like to use this feature as well.

@stale
Copy link

stale bot commented Aug 24, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Aug 24, 2020
@joereynolds
Copy link
Contributor Author

This is not stale, these changes still apply, pinging @w0rp

@stale stale bot removed the stale PRs a bot will close automatically label Aug 24, 2020
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add this to the supported tools, but I'll add it.

@w0rp w0rp merged commit 47fdc02 into dense-analysis:master Aug 28, 2020
@w0rp
Copy link
Member

w0rp commented Aug 28, 2020

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants