Fix 2816 - Standard fix does not work. #3046
Conversation
The standard linter --fix fails if the file being input is not relative to the project root (standard/standard#1384). This MR attempts to fix this by changing the command so the input file is relative to the project root and the output is to a temporary file. Preliminary tests with toy javascript projects seem to indicate this works fine.
|
Found this after being biten by #2816. I tested and can confirm that this PR fixes |
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
There was a problem hiding this comment.
I'll merge this.
I recommend everyone use ESLint instead of standard, with a standard configuration file if you really want all of the rules for StandardJS. I've never understood why there's a separate executable that behaves differently when it's really just ESLint under the hood.
|
Cheers! 🍻 |
The standard linter --fix fails if the file being input is not relative
to the project root (standard/standard#1384).
This MR attempts to fix this by changing the command so the input file
is relative to the project root and the output is to a temporary file.
Preliminary tests with toy javascript projects seem to indicate this
works fine.
Where are the tests? Have you added tests? Have you updated the tests? Read the
comment above and the documentation referenced in it first. Write tests!
Seriously, read
:help ale-devand write tests.