support project-level golangci-lint linting #3074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `g:ale_go_golangci_lint_scope` option replaces `g:ale_go_golangci_lint_package` and supports three different modes: * file * module * project The default is `file`, and means `golangci-lint` lints the current file. The `module` option inherits the behavior previously provided by `g:ale_go_golangci_lint_package`. The The new option `project` searches for the root of the Go project (either with a "go.mod" file, a ".git" directory, or within $GOPATH) and runs the linter from there.
|
I'm not sure yet why the CI is failing. Locally, the tests are passing ( |
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
g:ale_go_golangci_lint_scopeoption supersedesg:ale_go_golangci_lint_packageand supports three different modes:The default is
file, and meansgolangci-lintlints the current file.The
moduleoption inherits the behavior previously provided byg:ale_go_golangci_lint_package.The new option
projectsearches for the root of the Go project (either with a "go.mod" file, a ".git" directory, or within $GOPATH) and runs the linter from there.This is helpful in cases such as #2339 where the
unusedlint will report errors if it runs against a module or file, as opposed to from the project root.