Set prettier working directory to where .prettierignore is

[iclanzan]

Prettier does not use .prettierignore unless the current directory is the root where the .prettierignore file resides.

[RyanSquared]

related: #1095

[RyanSquared]

I don't see the reason why --stdin-filename required CdString.

[stale]

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

[iclanzan]

@w0rp do you think we can merge this?

[w0rp]

I don't think it's the right solution. Unless the CWD is set to something, it could be anything at all. For many linters, the CWD doesn't matter. If the CWD has to be the same as the directory that .prettierignore is in, we should use the ale#path#FindNearestFile function to find it and set the CWD to that directory. That way the fixer will always use the right directory even when people have configured Vim to set the CWD to other directories.

I have Vim configured to set the CWD automatically to the directory the current file I'm editing is in.

[iclanzan]

That wouldn’t work though because many projects don’t have a .prettierignore.

[w0rp]

We'd handle the path possibly being there or not. Here's just one example of another tool doing a similar thing.

function! ale_linters#cpp#cquery#GetProjectRoot(buffer) abort
    " Try to find cquery configuration files first.
    let l:config = ale#path#FindNearestFile(a:buffer, '.cquery')

    if !empty(l:config)
        return fnamemodify(l:config, ':h')
    endif

    " Fall back on default project root detection.
    return ale#c#FindProjectRoot(a:buffer)
endfunction

[w0rp]

I've re-opened this. You can make the changes we need.

[iclanzan]

Thanks for the guidance @w0rp, I think this is ready for another review!

[w0rp]

Cheers! 🍻