add gometalinter #312
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| let s:SplitChar = has('unix') ? ':' : ':' | ||
|
|
||
| let g:ale_linters#go#gometalinter#args = get(g:, 'ale_linters#go#gometalinter#args', [ | ||
| \ '--fast', | ||
| \ '--tests', | ||
| \ ]) | ||
|
|
||
| function! s:Args() abort | ||
| return join(map(copy(g:ale_linters#go#gometalinter#args), 'shellescape(v:val)'), ' ') | ||
| endfunction | ||
|
|
||
| function! ale_linters#go#gometalinter#GetCommand(buffer, copy_output) abort | ||
| let l:tempdir = a:copy_output[0] | ||
| let l:importpath = ale_linters#go#gobuild#PackageImportPath(a:buffer) | ||
| let l:gopaths = [ l:tempdir ] | ||
| call extend(l:gopaths, split(g:ale_linters#go#gobuild#go_env.GOPATH, s:SplitChar)) | ||
|
|
||
| return 'GOPATH=' . shellescape(join(l:gopaths, s:SplitChar)) . ' gometalinter ' . s:Args() . ' ' . shellescape(l:tempdir . '/src/' . l:importpath) | ||
| endfunction | ||
|
|
||
| let s:path_pattern = '[a-zA-Z]\?\\\?:\?[[:alnum:]/\.\-_]\+' | ||
| let s:handler_pattern = '^\(' . s:path_pattern . '\):\(\d\+\):\?\(\d\+\)\?:\?\([a-zA-Z]\+\): \(.\+\)$' | ||
|
|
||
| function! ale_linters#go#gometalinter#Handler(buffer, lines) abort | ||
| let l:output = [] | ||
|
|
||
| for l:line in a:lines | ||
| let l:match = matchlist(l:line, s:handler_pattern) | ||
|
|
||
| if len(l:match) == 0 | ||
| continue | ||
| endif | ||
|
|
||
| let l:buffer = ale_linters#go#gobuild#FindBuffer(l:match[1]) | ||
|
|
||
| if l:buffer == -1 | ||
| continue | ||
| endif | ||
|
|
||
| if !get(g:, 'ale_experimental_multibuffer', 0) && l:buffer != a:buffer | ||
| " strip lines from other buffers | ||
| continue | ||
| endif | ||
|
|
||
| call add(l:output, { | ||
| \ 'bufnr': l:buffer, | ||
| \ 'lnum': l:match[2] + 0, | ||
| \ 'vcol': 0, | ||
| \ 'col': l:match[3] + 0, | ||
| \ 'text': l:match[5], | ||
| \ 'type': toupper(l:match[4][0]), | ||
| \ 'nr': -1, | ||
| \}) | ||
| endfor | ||
|
|
||
| return l:output | ||
| endfunction | ||
|
|
||
| call ale#linter#Define('go', { | ||
| \ 'name': 'gometalinter', | ||
| \ 'executable': 'gometalinter', | ||
| \ 'command_chain': [ | ||
| \ {'callback': 'ale_linters#go#gobuild#GoEnv', 'output_stream': 'stdout'}, | ||
| \ {'callback': 'ale_linters#go#gobuild#GoList', 'output_stream': 'stdout'}, | ||
| \ {'callback': 'ale_linters#go#gobuild#CopyFiles', 'output_stream': 'stdout'}, | ||
| \ {'callback': 'ale_linters#go#gobuild#WriteBuffers', 'output_stream': 'stdout'}, | ||
| \ {'callback': 'ale_linters#go#gometalinter#GetCommand', 'output_stream': 'stdout'}, | ||
|
There was a problem hiding this comment. All of these There was a problem hiding this comment. It might be an idea to move functions shared between two linter definitions into the If anyone ever changes the way linters are loaded so only the list of enabled linters are loaded, which has tried before, then this code will break when only this linter is enabled for |
||
| \ ], | ||
| \ 'callback': 'ale_linters#go#gometalinter#Handler', | ||
| \}) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -90,6 +90,17 @@ function! ale#util#LocItemCompare(left, right) abort | |
| return 1 | ||
| endif | ||
|
|
||
| " put warnings after errors (for the same line) since the text that shows | ||
| " when the cursor is moved will show only the first entry | ||
|
|
||
| if a:left['type'] < a:right['type'] | ||
| return -1 | ||
| endif | ||
|
|
||
| if a:left['type'] > a:right['type'] | ||
| return 1 | ||
| endif | ||
|
There was a problem hiding this comment. This change will sort the items in the wrong order, which is important for the movement commands, etc. Instead of getting items in column order You should move these lines down below the column sorting, so it's the third key items are sorted on. Then There was a problem hiding this comment. If you're going to sort on the error type, you should take issue #149 into account. Eventually, I would like to support error types in some way beyond "warning" and "error". 'E' seems to be the first single character which could appear in lexicographic order, but 'I' comes before 'W' in lexicographic order, and 'W' is more severe than 'I', so that wouldn't be right. |
||
|
|
||
| if a:left['col'] < a:right['col'] | ||
| return -1 | ||
| endif | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could perhaps start implementing this flag in the function which fixes problems with the loclist items. If the flag isn't on, you could automatically remove items for other buffers in that function.