Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust/cargo: add support for a custom target directory #3164

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

mathstuf
Copy link
Contributor

This can avoid having to wait for ALE or ALE being blocked on other
cargo actions within the same crate.


Where are the tests?

Where should I add them? I don't see any existing ones testing this kind of feature already.

Seriously, read :help ale-dev and write tests.

@stale
Copy link

stale bot commented Aug 13, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs/Issues no longer valid label Aug 13, 2020
@mathstuf
Copy link
Contributor Author

Ping @w0rp to un-stale this :) . It's not clear to me how to test this since it is controlling a cargo behavior.

@stale stale bot removed the stale PRs/Issues no longer valid label Aug 13, 2020
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
ale_linters/rust/cargo.vim Outdated Show resolved Hide resolved
ale_linters/rust/cargo.vim Outdated Show resolved Hide resolved
@mathstuf
Copy link
Contributor Author

Thanks. Trying to run tests locally seems to hang with no CPU usage from the processes in the container...seeing what CI says.

@w0rp
Copy link
Member

w0rp commented Aug 13, 2020

Thanks. Trying to run tests locally seems to hang with no CPU usage from the processes in the container...seeing what CI says.

Yeah, I get that on my machine too. I haven't been able to figure out why the tests can do that, but if you just let them run for a while they will eventually exit and give you the results. At some point I'll try to figure out what is going on and fix that.

@w0rp
Copy link
Member

w0rp commented Aug 13, 2020

The upshot of them taking a while with low CPU usage is that you can go off and do whatever else you want for a while, because your CPUs will be free to do other work.

@mathstuf mathstuf force-pushed the cargo-separate-target-dir branch 2 times, most recently from b58988a to a0bfd58 Compare August 13, 2020 14:20
This can avoid having to wait for ALE or ALE being blocked on other
cargo actions within the same crate.
@mathstuf
Copy link
Contributor Author

Finally all green :) .

@w0rp w0rp merged commit ed69b07 into dense-analysis:master Aug 13, 2020
@w0rp
Copy link
Member

w0rp commented Aug 13, 2020

Cheers! 🍻

@mathstuf mathstuf deleted the cargo-separate-target-dir branch September 10, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants